node-qt-napi icon indicating copy to clipboard operation
node-qt-napi copied to clipboard

Published 20 hours ago • verified publisher icon kusti8

Expose showFullScreen and showNormal methods of QMainWindow

Open katafrakt opened this issue 5 years ago • 2 comments

I would love to see fullscreen windows in proton-native. I've manage to get it run locally, but first exposing methods here seems to be required.

I only added support for showFullScreen and showNormal, without maximized and minimized (I think I have never seen an app using them), but those too can be added too. Or maybe you think it would be better to control it via setWindowStates(Qt::WindowFullScreen)?

As there's no readme, I don't know if I should commit .moc files. Also version was automatically bumped up and I commited that too.

Let me know what you think.

katafrakt avatar Jan 24 '20 18:01 katafrakt

Okay, I figured it's better not to touch .moc, as MacOSX and Windows don't like it. Now the builds are green.

katafrakt avatar Feb 03 '20 09:02 katafrakt

@kusti8 any thoughts?

katafrakt avatar Aug 10 '20 00:08 katafrakt