test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Use a public ubuntu image for kubelet node e2e tests

Open upodroid opened this issue 2 years ago • 10 comments

I'll post the test results in a follow up comment.

This is a helpful step for running e2e tests on the same OS in AWS.

@dims

upodroid avatar Feb 27 '23 15:02 upodroid

/assign @endocrimes @SergeyKanzhelev

dims avatar Feb 27 '23 16:02 dims

5 tests are failing on the public ubuntu images. I'm going to open an issue in k/k for resolving the bugs/image config(I suspect it is most likely the cloud-init config which should be documented.)

Build Args:

REDACTED@knative-e2e:~/tz-kubernetes$ cat ~/k8s-test-infra/jobs/e2e_node/containerd/containerd-main/image-config.yaml
images:
  ubuntu:
    image_family: ubuntu-2204-lts
    project: ubuntu-os-cloud
    metadata: "user-data</home/REDACTED/k8s-test-infra/jobs/e2e_node/containerd/containerd-main/ubuntu-init.yaml"
    
 
REDACTED@knative-e2e:~/tz-kubernetes$ make test-e2e-node REMOTE=true REMOTE_MODE=gce IMAGE_CONFIG_FILE=~/k8s-test-infra/jobs/e2e_node/containerd/containerd-main/image-config.yaml

Result

Summarizing 5 Failures:
  [FAIL] [sig-node] Summary API [NodeConformance] when querying /stats/summary [It] should report resource usage through the stats api
  test/e2e_node/summary_test.go:332
  [FAIL] [sig-node] Pods [It] should delete a collection of pods [Conformance]
  test/e2e/common/node/pods.go:877
  [FAIL] [sig-node] Security Context When creating a pod with HostUsers [It] must create the user namespace if set to false [LinuxOnly] [Feature:UserNamespacesStatelessPodsSupport]
  test/e2e/common/node/security_context.go:106
  [FAIL] [sig-node] Pods [It] should run through the lifecycle of Pods and PodStatus [Conformance]
  test/e2e/common/node/pods.go:959
  [FAIL] [sig-node] Pods [It] should patch a pod status [Conformance]
  test/e2e/common/node/pods.go:1108

Ran 261 of 390 Specs in 887.151 seconds
FAIL! -- 256 Passed | 5 Failed | 0 Pending | 129 Skipped


Ginkgo ran 1 suite in 14m48.016348681s

Test Suite Failed
You're using deprecated Ginkgo functionality:
=============================================
  --untilItFails is deprecated, use --until-it-fails instead
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.7.0


Failure Finished Test Suite on Host test-ubuntu-2204-jammy-v20230214
command [ssh -o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR -i /home/maha4472/.ssh/google_compute_engine [email protected] -- sudo sh -c 'cd /tmp/node-e2e-20230227T222612 && timeout -k 30s 2700.000000s ./ginkgo -timeout=24h -nodes=8  -skip="\[Flaky\]|\[Slow\]|\[Serial\]"  -untilItFails=false  ./e2e_node.test -- --system-spec-name= --system-spec-file= --extra-envs= --runtime-config= --v 4 --node-name=test-ubuntu-2204-jammy-v20230214 --report-dir=/tmp/node-e2e-20230227T222612/results --report-prefix=ubuntu --image-description="ubuntu-2204-jammy-v20230214" --kubelet-flags=--kernel-memcg-notification=true --kubelet-flags=--feature-gates=DisableKubeletCloudCredentialProviders=true,KubeletCredentialProviders=true --kubelet-flags=--image-credential-provider-config=/tmp/node-e2e-20230227T222612/credential-provider.yaml --kubelet-flags=--image-credential-provider-bin-dir=/tmp/node-e2e-20230227T222612 --kubelet-flags="--cluster-domain=cluster.local" --dns-domain="cluster.local" --container-runtime-endpoint=unix:///run/containerd/containerd.sock '] failed with error: exit status 1

upodroid avatar Feb 27 '23 22:02 upodroid

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: upodroid Once this PR has been reviewed and has the lgtm label, please ask for approval from endocrimes. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 06 '23 22:03 k8s-ci-robot

This is ready to be merged after https://github.com/containerd/containerd/pull/8170 is merged. The tests pass when I use the same flags as the prowjobs.

Flags

make test-e2e-node REMOTE=true REMOTE_MODE=gce IMAGE_CONFIG_FILE=~/k8s-test-infra/jobs/e2e_node/containerd/containerd-main/image-config.yaml FOCUS="\[NodeConformance\]" TEST_ARGS='--container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/usr/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd*\"]}"'

Result

------------------------------
[ReportAfterSuite] PASSED [0.018 seconds]
[ReportAfterSuite] Kubernetes e2e JUnit report
test/e2e/framework/test_context.go:591
------------------------------

Ran 184 of 392 Specs in 680.966 seconds
SUCCESS! -- 184 Passed | 0 Failed | 0 Pending | 208 Skipped


Ginkgo ran 1 suite in 11m21.803631718s
Test Suite Passed
You're using deprecated Ginkgo functionality:
=============================================
  --untilItFails is deprecated, use --until-it-fails instead
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.7.0


Success Finished Test Suite on Host test-ubuntu-2204-jammy-v20230302. Refer to artifacts directory for ginkgo log for this host.
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
<                              FINISH TEST                               <
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

upodroid avatar Mar 07 '23 18:03 upodroid

/cc @tzneal

SergeyKanzhelev avatar May 17 '23 17:05 SergeyKanzhelev

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 01 '23 01:07 k8s-ci-robot

needs rebase @upodroid

dims avatar Jul 01 '23 12:07 dims

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 20 '24 08:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 19 '24 08:02 k8s-triage-robot

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-misc-image-build-test 4b06459638a5d9b231d293549d24249542d5e2ee link true /test pull-test-infra-misc-image-build-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 09 '24 23:04 k8s-ci-robot