node-problem-detector

node-problem-detector copied to clipboard

Add MartinForReal as a reviewer

PR: https://github.com/kubernetes/node-problem-detector/pull/756 https://github.com/kubernetes/node-problem-detector/pull/760 https://github.com/kubernetes/node-problem-detector/pull/769 https://github.com/kubernetes/node-problem-detector/pull/773 https://github.com/kubernetes/node-problem-detector/pull/774 https://github.com/kubernetes/node-problem-detector/pull/793 https://github.com/kubernetes/node-problem-detector/pull/806 https://github.com/kubernetes/node-problem-detector/pull/820 https://github.com/kubernetes/node-problem-detector/pull/811 in review.

Reviewed pr: https://github.com/kubernetes/node-problem-detector/pull/823 https://github.com/kubernetes/node-problem-detector/pull/806 https://github.com/kubernetes/node-problem-detector/pull/774 https://github.com/kubernetes/node-problem-detector/pull/761

/test pull-npd-build

Thank you for the contribution, Would you mind the adding the evidence based on the https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-2

@vteratipally I see that @MartinForReal wants to join as a Reviewer, which has different kind of requirements. https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer

Pretty sure they are all requirements are met, maybe even for approver status. /lgtm /cc @dims

It would be helpful in reviewing the PR with the evidence added based on the requirements.

@MartinForReal for the record, can you please add details in the PR body? (as mentioned in https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-1)

- member for at least 3 months
- Primary reviewer for at least 5 PRs to the codebase
- Reviewed or merged at least 20 substantial PRs to the codebase
- Knowledgeable about the codebase
- Sponsored by a subproject approver
- With no objections from other approvers
- Done through PR to update the OWNERS file
- May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

Note that sig-node bar is very similar as well https://github.com/kubernetes/community/blob/master/sig-node/sig-node-contributor-ladder.md#reviewer (cc @vteratipally)

@hakman @vteratipally Would you like to be my sponsor? Thanks!

@hakman @vteratipally Would you like to be my sponsor? Thanks!

Sure, I'm fine with that. /lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hakman, MartinForReal Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/retest

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale