enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-4603: initial KEP for Tune CrashLoopBackoff

Open lauralorenz opened this issue 1 year ago • 6 comments

  • One-line PR description: Adding new KEP
  • Issue link: #4603
  • Other comments: Summary, Motivation, Proposal, Design Details, Grad criteria and PRR ready for review. Still tweaking some prose on Alternatives and and Notes/Constraints/Caveats.

lauralorenz avatar Apr 30 '24 04:04 lauralorenz

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Apr 30 '24 04:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lauralorenz Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 30 '24 04:04 k8s-ci-robot

/retest

lauralorenz avatar Jun 12 '24 01:06 lauralorenz

/unassign

mrbobbytables avatar Jun 12 '24 19:06 mrbobbytables

/retest

lauralorenz avatar Jun 12 '24 20:06 lauralorenz

Hiya @soltysh, thank you SO MUCH for your PRR review and comments. I did decide today with @tallclair to wait for 1.32 to put this in an actual release because we don't like the API I suggested enough for how complicated it might be to back out of it. Just wanted to take it off your radar on this most auspicious day, 1.31 enhancements freeze ;)

lauralorenz avatar Jun 13 '24 19:06 lauralorenz

I've updated this PR to be valid as to merge now in a provisional state, without the PRR, and with several UNRESOLVED blocks, so I can separate out the updates to the 1.32 variation so that can be handled in a separate, clean PR for discussion.

lauralorenz avatar Sep 09 '24 22:09 lauralorenz

/assign @SergeyKanzhelev for approval

bart0sh avatar Sep 19 '24 16:09 bart0sh

FYI to connect the dots for posterity, 1.32 PR (draft right now) is at https://github.com/lauralorenz/enhancements/pull/21

UPDATE: PR into k/k is at https://github.com/kubernetes/enhancements/pull/4893

lauralorenz avatar Sep 20 '24 21:09 lauralorenz

/lgtm

tallclair avatar Oct 01 '24 18:10 tallclair

There are the following unresolved topics:

  • Rapid Restart Implementation
  • Node-Level Opt-in
  • Benchmarking and Stress Testing
  • Interaction with Job API
  • Kubelet Overhead Analysis

@lauralorenz and @tallclair indicates they are going to be covered in the following KEP PRs for 1.32, which makes this implementable.

/approve at the provisional state

dchen1107 avatar Oct 01 '24 21:10 dchen1107

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, lauralorenz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 01 '24 21:10 k8s-ci-robot

Thanks all! PR into k/k for 1.32 is at https://github.com/kubernetes/enhancements/pull/4893

lauralorenz avatar Oct 02 '24 04:10 lauralorenz