enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Job success/completion policy

Open tenzen-y opened this issue 2 years ago • 32 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): An API to define when a Job can be declared as succeeded based on the number of succeeded pods.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/3998-job-success-completion-policy
  • Discussion Link: https://github.com/kubernetes/kubernetes/issues/117600
  • Primary contact (assignee): @tenzen-y
  • Responsible SIGs: sig-apps
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): v1.30
    • Beta release target (x.y): v1.31
    • Stable release target (x.y):
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • [x] https://github.com/kubernetes/enhancements/pull/4062
      • [x] https://github.com/kubernetes/enhancements/pull/4537
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/123412
      • [x] https://github.com/kubernetes/kubernetes/pull/123826
    • [x] Docs (k/website) update PR(s):
      • [x] https://github.com/kubernetes/website/pull/45135
      • [x] https://github.com/kubernetes/website/pull/45677
      • [x] https://github.com/kubernetes/website/pull/45274
  • [ ] Beta
    • [x] KEP (k/enhancements) update PR(s): #4702
    • [ ] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/125429
    • [ ] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/46970

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig apps /wg batch /assign

tenzen-y avatar May 12 '23 06:05 tenzen-y

@soltysh I'm not sure if this will make it to the enhancements freeze, but would you consider a lead-opted-in?

alculquicondor avatar Jun 13 '23 20:06 alculquicondor

@soltysh I'm not sure if this will make it to the enhancements freeze, but would you consider a lead-opted-in?

Sorry, I won't be able to get there before today's freeze

soltysh avatar Jun 15 '23 14:06 soltysh

Since many discussions are left, I will try to complete it for the next release cycle (v1.29). Thanks to everyone!

tenzen-y avatar Jun 15 '23 21:06 tenzen-y

Hey @tenzen-y,

Are you still working on this KEP?

I just finished graduation of the PodReplacementPolicy to Beta and I have capacity to take on additional work if you don't have capacity to work on this KEP.

dejanzele avatar Oct 30 '23 19:10 dejanzele

KEP-3998: Job success/completion policy #4062

I'm working on this now. I will move this forward in the next release cycle (v1.30) since the enhancement freeze for this release (v1.29) came.

https://github.com/kubernetes/enhancements/pull/4062#issuecomment-1748926798

tenzen-y avatar Oct 30 '23 19:10 tenzen-y

@soltysh since the KEP is being reviewed, did you consider adding this as a feature for sig-apps for 1.30?

kannon92 avatar Jan 24 '24 20:01 kannon92

/label lead-opted-in /milestone v1.30 /stage alpha

soltysh avatar Jan 26 '24 14:01 soltysh

Hello @tenzen-y 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.30.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Make sure the PR with the information get merged before enhancement freeze, I just found this PR.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

pnbrown avatar Feb 07 '24 15:02 pnbrown

@pnbrown Thank you for contacting me.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

This enhancement is still targeting for alpha stage. Could you confirm again?

tenzen-y avatar Feb 07 '24 16:02 tenzen-y

That's my mistake. Editing now

pnbrown avatar Feb 07 '24 16:02 pnbrown

That's my mistake. Editing now

Thanks.

tenzen-y avatar Feb 07 '24 16:02 tenzen-y

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

pnbrown avatar Feb 09 '24 02:02 pnbrown

Hi @tenzen-y!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

celestehorgan avatar Feb 14 '24 11:02 celestehorgan

Hi @tenzen-y!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Sure. Thank you for reminding me! Created: https://github.com/kubernetes/website/pull/45135

tenzen-y avatar Feb 14 '24 14:02 tenzen-y

Hi @tenzen-y,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

natalisucks avatar Feb 15 '24 12:02 natalisucks

Hi @tenzen-y,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@natalisucks Hi, thank you for contacting me. I created a placeholder PR here: https://github.com/kubernetes/website/pull/45274.

tenzen-y avatar Feb 22 '24 03:02 tenzen-y

Hey again @tenzen-y 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

  • https://github.com/kubernetes/kubernetes/pull/123412

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

pnbrown avatar Feb 29 '24 00:02 pnbrown

With the exception request being approved, this can now be marked as tracked for code freeze

salehsedghpour avatar Mar 06 '24 19:03 salehsedghpour