enhancements

enhancements copied to clipboard

• One-line PR description: Update the CEL admission KEP to support graceful policy rollout by adding ability to report validation failures only as warnings or audit annotations and for enhancing metrics to container the information needed to monitor a rollout.

• Issue link: #3492

cc @maxsmythe @cici37 @liggitt @tallclair @andrewsykim

cc @liggitt

/assign @deads2k @lavalamp Here is another small KEP update to ValidatingAdmissionPolicy is ready for an approver pass.

LGTM but two comments for you to look at first

Feedback applied. I've left some of the comment threads open where further discussion might be needed.

thanks for the update, I did a quick sweep and my open questions were resolved

@deads2k @lavalamp All open issues on this one are resolved. It's ready for another approver pass.

Thanks @tallclair, I've incorporated the feedback into the KEP. I've left some of the comments open until you've gotten a chance to respond.

@lavalamp this is ready for another approver pass.

Thanks @lavalamp, feedback applied.

/lgtm /approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~keps/sig-api-machinery/OWNERS~~ [jpbetz,lavalamp]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment