enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

KEP-3352 Aggregated Discovery to Beta

Open Jefftree opened this issue 2 years ago • 4 comments

  • One-line PR description: Update milestone aggregated discovery to beta 1.27
  • Issue link: https://github.com/kubernetes/enhancements/issues/3352
  • Other comments: /cc @apelisse @lavalamp @deads2k @alexzielenski

Jefftree avatar Jan 10 '23 19:01 Jefftree

LGTM except for two comments!

lavalamp avatar Jan 18 '23 00:01 lavalamp

Addressed all comments, PTAL thanks!

Jefftree avatar Jan 18 '23 15:01 Jefftree

/lgtm /approve

in case @deads2k wants to review, I'll /hold for a day or two.

lavalamp avatar Jan 18 '23 18:01 lavalamp

Thanks, lgtm for both sig and PRR

/lgtm /approve /hold cancel

deads2k avatar Jan 23 '23 22:01 deads2k

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Jefftree, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 23 '23 22:01 k8s-ci-robot

Looks like PRR review was already conducted on this KEP, so I will not re-review.

logicalhan avatar Feb 02 '23 14:02 logicalhan