enhancements

enhancements copied to clipboard

• One-line PR description: adding new KEP

• Issue link: https://github.com/kubernetes/enhancements/issues/3542

• Other comments:

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: byako Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval by writing /assign @derekwaynecarr in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• keps/sig-node/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Welcome @byako!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

Hi @byako. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: byako / name: Alexey Fomenko (85001234adc3a1a65b3de390925c293873e6a78e, 4d6658ce91234bc288946c1fc3229f684a1099ec, 9b131bc12d17cf4521eeab5d6d8cdc1a1e07e631, ae0ea7f796dcce547dd94e5997c018bb47852b25, d9cda949b72fb3fd662564b7912f7d629894ed87, 596f2e8eddec8bdae1a2a91fd9b8da2ac94729ce, 8eb36bb8b7f14130c2c32e9997ee96a423907833, f566f5aacb12127af80bcf7a63bc9bdfbbda0601, fc62426b29e6cb561ff1410a7444db628bd30516, 4d68f2a410a789408918f07bafc6c624571d60e6, f0b3f14aa77a9b4a69bb8736865985ebe19cadd7, f0d3191f6cb7f55854303a481cad62095901e7a3, 4c336d2668f29b2fdc91b81e71deecd2eeac3c45, 385927a70a49666595294ed0e02a7f6c883a1c41, db96b99f7c3c1c67cf2b91168cea9d5e42790cfb, 558f8f2a8f929033c04840e029a572481f769510, a62798011f0e8414f1af11e3321138c854b8bfca, 390963245774528ebdedea4b86c0cbcda15c494d, d62526c0d37b2e02ff520ecdb84bf40cd2609061, 6c54bc9332c13652812e99c8738948570570cf97, 8046f4345d5799103b883465bff0963ad624f616, deed25ec4d272b742e93a423f99dcff8ef1b1de5, f920a3c4e266966ecdcf3366487c750d6dd3e373, 8fe94b500026cea7cff6a3e350b0692f0d35808a, 92638ba82ac416b36349fd72a523195ae66cacb9, cd73d092e120a55521b75724564bdccf9ea34156, 3208dd234434c32a5e085cd7ae5e394b7981dc78, 73fb9e942bf83c74e58e9eb3bd3205790a01bd6b, d40d49b10470c83a78271390f2aa152ea20e0bef, 60732b6956aa6dea7657e6f4358cea96e9ae0140, f8867f3179786d1b18ffdf7694e19cba36bc75e2, 75920a66174d2fb5aa99017a88ba1708dc265628, 92e8f111015e65d6c7cc5b4b3f3271a62abdf246, 22ec9c18a1342574c4e27763bdee1880f9954cc6)
• :white_check_mark: login: jukkar / name: Jukka Rissanen (fa0339a4cd3b844194e03fe1bbb895c3e6a26dfe, cd39253ec2a526c157155d9116c6b6d3ef7acb18)
• :white_check_mark: login: mikebrow / name: Mike Brown (db96b99f7c3c1c67cf2b91168cea9d5e42790cfb, 558f8f2a8f929033c04840e029a572481f769510, a62798011f0e8414f1af11e3321138c854b8bfca, 390963245774528ebdedea4b86c0cbcda15c494d, d62526c0d37b2e02ff520ecdb84bf40cd2609061, 6c54bc9332c13652812e99c8738948570570cf97)

@byako: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-enhancements-test	d9cda949b72fb3fd662564b7912f7d629894ed87	link	true	/test pull-enhancements-test
pull-enhancements-verify	d9cda949b72fb3fd662564b7912f7d629894ed87	link	true	/test pull-enhancements-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@byako please fix failing CI tests, thanks.

Planning to start working on this right after KubeCon EU '23.

/cc

Kubelet PoC implementation https://github.com/kubernetes/kubernetes/pull/118326

/assign @mikebrow

/assign

/assign

/lgtm

New changes are detected. LGTM label has been removed.

@byako checking if you saw https://github.com/kubernetes/enhancements/pull/3547#discussion_r1229802820 these threads scroll up fast.. :)

@mrunalp , @mikebrow I've changed status to Implementable, in kep.yaml, do you agree? Can we approve this and proceed with implementation if the KEP exception is granted?

Changed back to provisional, moved alpha to 1.29, is PRR needed for this KEP to get merged in provisional status ?

LTGM just a couple nits regarding notice of additional overhead to be determined and reported.

This still needs approval, unless there are new concerns.

@ruiwen-zhao , seem this is ready for approval, could you please label this so it can go to PRR ?

/assign @mrunalp for approval

@byako: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @mrunalp for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: byako, mikebrow Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• keps/prod-readiness/OWNERS
• keps/sig-node/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/milestone clear as we miss the enhancement freeze and no exception is open yet.

I cannot request exception for this, SIG leadership does not approve this, I'll have to move this to next release.

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/stage alpha /milestone v1.30

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

/remove-lifecycle rotten

/milestone clear

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale