enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Allow StatefulSet to control start replica ordinal numbering

Open pwschuurman opened this issue 3 years ago • 54 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Added a feature that allows a StatefulSet to start numbering replicas from an arbitrary non-negative ordinal, using the .spec.ordinals.start field.
    • KEP-3335 Link
    • KEP-3335 PR: https://github.com/kubernetes/enhancements/pull/3336
  • Discussion Link:
  • Primary contact (assignee): @pwschuurman
  • Responsible SIGs: sig-apps, sig-multicluster, sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.26
    • Beta release target (x.y): 1.27
    • Stable release target (x.y): 1.31
  • [X] Alpha
    • [X] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3336
    • [X] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/112744
    • [X] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/37224
  • [X] Beta
    • [X] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3768
    • [X] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/115260
    • [x] Metrics (k/kube-state-metrics) update PR(s): https://github.com/kubernetes/kube-state-metrics/pull/1959
    • [X] Tests (k/k) unit PR(s): https://github.com/kubernetes/kubernetes/pull/115536
    • [X] Tests (k/k) integration PR(s): https://github.com/kubernetes/kubernetes/pull/115466
    • [X] Tests (k/k) e2e PR(s): https://github.com/kubernetes/kubernetes/pull/115468
    • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/39823
  • [ ] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4694
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/125374
    • [ ] Metrics (k/kube-state-metrics) update PR(s): https://github.com/kubernetes/kube-state-metrics/pull/2415
    • [ ] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/46719

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

pwschuurman avatar Jun 03 '22 06:06 pwschuurman

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 01 '22 07:09 k8s-triage-robot

/sig multicluster

pwschuurman avatar Sep 19 '22 17:09 pwschuurman

/label lead-opted-in

JeremyOT avatar Sep 20 '22 20:09 JeremyOT

/milestone v1.26 /label tracked/yes /stage alpha

rhockenbury avatar Sep 21 '22 01:09 rhockenbury

Hello @pwschuurman 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.26
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to merge https://github.com/kubernetes/enhancements/pull/3336, which will take care of above requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Sep 27 '22 02:09 ruheenaansari34

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to get the PR https://github.com/kubernetes/enhancements/pull/3336 merged.

ruheenaansari34 avatar Oct 04 '22 15:10 ruheenaansari34

Hi @ruheenaansari34, #3336 has been merged.

pwschuurman avatar Oct 06 '22 17:10 pwschuurman

/sig apps

pwschuurman avatar Oct 06 '22 17:10 pwschuurman

/remove-sig multicluster

pwschuurman avatar Oct 06 '22 17:10 pwschuurman

Thanks, the enhancements team has this marked as tracked now.

rhockenbury avatar Oct 06 '22 20:10 rhockenbury

/remove-lifecycle stale

soltysh avatar Oct 07 '22 08:10 soltysh

  • Docs draft PR: https://github.com/kubernetes/website/pull/37224

pwschuurman avatar Oct 08 '22 21:10 pwschuurman

Hi @ruheenaansari34 @rhockenbury, this is currently marked as tracked by sig-multicluster, but the KEP is in sig-apps. Can the enhancements spreadsheet be updated to reflect the current state of this enhancement? https://github.com/orgs/kubernetes/projects/98/views/11?sortedBy%5Bdirection%5D=asc&sortedBy%5BcolumnId%5D=15217749&filterQuery=sig%3Asig-multicluster

pwschuurman avatar Oct 14 '22 22:10 pwschuurman

Thanks. Fixed.

rhockenbury avatar Oct 15 '22 17:10 rhockenbury

Hi @pwschuurman 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes). Open PR
  • [ ] All PRs are fully merged by the code freeze deadline.

For this enhancement, please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked.

As always, we are here to help should questions come up. Thanks!

parul5sahoo avatar Nov 01 '22 13:11 parul5sahoo

Hi there @pwschuurman 👋 1.26 Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for 1.26 release. I see you've opened https://github.com/kubernetes/website/pull/37224. I'd like to confirm that all Docs related changes will be included in this PR.

If not, please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

cathchu avatar Nov 02 '22 03:11 cathchu

Hi there @pwschuurman wave 1.26 Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for 1.26 release. I see you've opened kubernetes/website#37224. I'd like to confirm that all Docs related changes will be included in this PR.

If not, please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

Thanks @cathchu, yes ubernetes/website/pull/37224 is the only documentation associated with this PR. I do have a blog as well, but this is tracked by the communications team.

pwschuurman avatar Nov 02 '22 16:11 pwschuurman

Hey @pwschuurman,

As the Code freeze is just a day away, just wanted to confirm that there are no other open PRs in the K/K repo or any repo in general for this enhancement except for the ones outlined in the issues description? Please try to get the open PRs merged before code freeze, so that the enhancement can be marked tracked.

parul5sahoo avatar Nov 07 '22 05:11 parul5sahoo

Hi @parul5sahoo, yes this is the only k/k PR. There arare two other PRs, one for documentation and one for the blog post. Working on getting the k/k PR submitted today

pwschuurman avatar Nov 08 '22 07:11 pwschuurman

Please try to get it merged before Code Freeze.

parul5sahoo avatar Nov 08 '22 15:11 parul5sahoo

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

rhockenbury avatar Nov 09 '22 01:11 rhockenbury

Hi @rhockenbury I just filed for an exception request: https://groups.google.com/g/kubernetes-sig-apps/c/SqUMOWxwwpo

This exception is just pending on a single PR (https://github.com/kubernetes/kubernetes/pull/112744), which has been signed off by sig-apps and is just pending final API review.

pwschuurman avatar Nov 09 '22 02:11 pwschuurman

exception request accepted

/milestone v1.26 /label tracked/yes /label lead-opted-in /remove tracked/no

leonardpahlke avatar Nov 09 '22 20:11 leonardpahlke

/remove-label tracked/no

leonardpahlke avatar Nov 09 '22 20:11 leonardpahlke

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

marosset avatar Dec 14 '22 19:12 marosset

@pwschuurman are you planning to promote this to beta in 1.27?

soltysh avatar Jan 12 '23 15:01 soltysh

@soltysh Yes, I would like to promote to beta in 1.27. Working on the testing requirements for KEP in beta.

pwschuurman avatar Jan 14 '23 00:01 pwschuurman

@soltysh Would you be able to opt this KEP in for 1.27 release milestone (https://www.kubernetes.dev/blog/2022/09/09/enhancements-opt-in/)?

pwschuurman avatar Jan 31 '23 06:01 pwschuurman

/label lead-opted-in /milestone v1.27 /stage beta

soltysh avatar Jan 31 '23 13:01 soltysh

@soltysh Do you mind to take a look at https://github.com/kubernetes/kubernetes/pull/115468? I'd like to get the e2e tests submitted and running in testgrid (https://testgrid.k8s.io/google-gce#gci-gce-alpha-enabled-default) so we can have a clear signal prior to promoting the feature flag.

pwschuurman avatar Feb 02 '23 06:02 pwschuurman