enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

CephFS in-tree provisioner to CSI driver migration

Open humblec opened this issue 4 years ago β€’ 26 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note):
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
  • Discussion Link:
  • Primary contact (assignee): @humblec
  • Responsible SIGs: sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.25
    • Beta release target (x.y): 1.26
    • Stable release target (x.y): 1.27
  • [ ] Alpha
    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update PR(s):

Parent Enhancement #625

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

humblec avatar Sep 01 '21 13:09 humblec

/sig storage

humblec avatar Sep 01 '21 13:09 humblec

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 30 '21 13:11 k8s-triage-robot

/remove-lifecycle stale

humblec avatar Jan 05 '22 09:01 humblec

@Jiawei0227 would like to track this for 1.24 as alpha.

humblec avatar Jan 05 '22 09:01 humblec

@Jiawei0227 would like to track this for 1.24 as alpha.

SG! Thanks

Jiawei0227 avatar Jan 05 '22 10:01 Jiawei0227

/milestone v1.24

xing-yang avatar Jan 11 '22 03:01 xing-yang

Hello @humblec

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

  • [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for this release
  • [X] KEP has a test plan section filled out.
  • [X] KEP has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue description and the targeted stage up-to-date for release v1.24. Thanks!

hosseinsalahi avatar Jan 21 '22 09:01 hosseinsalahi

@encodeflush this is targetted as alpha in 1.24 and not beta, to be clear.

humblec avatar Jan 27 '22 16:01 humblec

Hi @humblec, 1.24 Docs shadow here. πŸ‘‹

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! πŸ™Œ

didicodes avatar Feb 13 '22 19:02 didicodes

The in-tree cephfs only support inline volume source model ( only mounter inteface) at present, that said, provision and delete implementation is missing or unknown to this driver.

https://github.com/kubernetes/examples/blob/master/volumes/cephfs/cephfs.yaml

I am wondering while we come up with migration for this plugin, what could/would be the expectation?

  • [ ] Is it supposed to be only mounter (mount/unmount) support after migration has been switched on [1]? or
  • [ ] can we think about provision/delete with migration ON, but directed to CSI driver ?

One thing to note here is, this plugin/driver dont have a SC support atm in in-tree, so bringing up the same to support provision/delete support with migration may not make much sense as it can be directly on CSI provisioner, instead of taking the route through the in-tree.

If the expectation is just to support "mounter" for existing volumes, do we anticipate any issues with the lack of implementation this driver currently has ?

I would like to request your input before taking this further. @Jiawei0227 @msau42 @jsafrane @xing-yang

[1] Even for mounter support , there are some glitches, which I am still exploring or trying to figure out.

humblec avatar Mar 09 '22 12:03 humblec

IMO the first option makes more sense. Existing PVs should migrate silently to CSI and that's it. We should not add new features to in-tree volumes, even if they're migrated to CSI.

If anyone wants to use dynamic provisioning, they can keep using the existing external provisioner(s) (they should be deprecated, if we have such power) and users should be advised to use CSI driver for provisioning.

jsafrane avatar Mar 09 '22 13:03 jsafrane

Thanks @jsafrane etl.al for sharing the thoughts! Let me check further on this. :+1:

humblec avatar Mar 15 '22 13:03 humblec

Hello @humblec

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • [X] All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • [X] Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as tracked. Thank you!

hosseinsalahi avatar Mar 21 '22 17:03 hosseinsalahi

@Jiawei0227 @xing-yang @encodeflush eventhough I am close to completion of this feature, some more time is required for wrapping it completely which includes more validation of different scenarios, e2e testing..etc.. considering we are at last hour of code freeze, imo, its better to reconsider for next release. with that, I would like to request to untrack this feature for 1.24 release.

humblec avatar Mar 29 '22 13:03 humblec

/milestone v1.25

xing-yang avatar May 23 '22 21:05 xing-yang

πŸ‘‹ Hello @humblec,

1.25 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [X] KEP has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we need to merge:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

rhockenbury avatar Jun 04 '22 18:06 rhockenbury

With #3357 merged, I have this marked as tracked for the v1.25 cycle. Thanks!

rhockenbury avatar Jun 15 '22 00:06 rhockenbury

Hello @humblec πŸ‘‹, 1.25 Release Docs shadow here. This enhancement is marked as β€˜Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

krol3 avatar Jul 13 '22 12:07 krol3

Hi @humblec πŸ‘‹

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.
    • https://github.com/kubernetes/kubernetes/pull/111137

Please verify, if there are any additional k/k PRs besides the ones listed above. Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk. Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

jasonbraganza avatar Jul 25 '22 06:07 jasonbraganza

Hello @humblec πŸ‘‹

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022. (less than a week to go) Please plan to have the k/k PR merged before then.

The status of this enhancement is currently marked as at risk

Thank you.

jasonbraganza avatar Jul 29 '22 12:07 jasonbraganza

Hello :wave:, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

Priyankasaggu11929 avatar Aug 03 '22 01:08 Priyankasaggu11929

/milestone v1.26

xing-yang avatar Sep 16 '22 01:09 xing-yang

KEP is merged: https://github.com/kubernetes/enhancements/pull/3530

xing-yang avatar Sep 21 '22 13:09 xing-yang

Hello @humblec πŸ‘‹, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.26
  • [x] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Create a PR to update KEP readme using the latest template.
  • Include graduation criteria in the KEP readme.
  • Merge the PR with above mentioned changes to meet the requirements of Enhancement freeze.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Sep 27 '22 01:09 ruheenaansari34

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README and get the PR merged.

ruheenaansari34 avatar Oct 04 '22 15:10 ruheenaansari34

With #3430 merged, this is marked as Tracked for v1.26.

rhockenbury avatar Oct 07 '22 01:10 rhockenbury

Hi @humblec πŸ‘‹,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

For this enhancement, I did not see any k/k PRs linked to this issue. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue (and update the issue description).

As always, we are here to help should questions come up. Thanks!

marosset avatar Oct 31 '22 19:10 marosset

Hi @marosset,

Just chatted with @humblec and confirmed that this is not targeting 1.26 any more. Please remove this from the tracking board. Thanks!

xing-yang avatar Nov 04 '22 12:11 xing-yang

/milestone clear

xing-yang avatar Nov 04 '22 12:11 xing-yang

/label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

rhockenbury avatar Nov 09 '22 00:11 rhockenbury