enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Ceph RBD in-tree provisioner to CSI driver migration

Open humblec opened this issue 4 years ago β€’ 49 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note):
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
  • Discussion Link:
  • Primary contact (assignee): @humblec
  • Responsible SIGs: sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.23
    • Beta release target (x.y): 1.27
    • Stable release target (x.y): 1.28
  • [ ] Alpha
    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/95361
    • [ ] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/30533

Parent Enhancement #625

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

humblec avatar Sep 01 '21 13:09 humblec

/sig storage

humblec avatar Sep 01 '21 13:09 humblec

/cc @msau42 @xing-yang @saad-ali @jsafrane

Jiawei0227 avatar Sep 02 '21 18:09 Jiawei0227

/assign @humblec

humblec avatar Sep 03 '21 14:09 humblec

Can you please migrate this to the latest enhancements template out of the community repo and fill out the PRR questionnaire, including the version skew and upgrade strategy sections?

ehashman avatar Sep 03 '21 21:09 ehashman

This is the kep in the new format: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration

msau42 avatar Sep 03 '21 23:09 msau42

A dedicated KEP for this enhancement is out for review: https://github.com/kubernetes/enhancements/pull/2963

Jiawei0227 avatar Sep 08 '21 23:09 Jiawei0227

Hi, 1.23 Enhancements Lead here πŸ‘‹. With enhancements freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP is merged into k/enhancements repo with up to date latest milestone and stage.
  • KEP status is marked as implementable.
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review for the correct stage that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

salaxander avatar Sep 10 '21 07:09 salaxander

@Jiawei0227 @msau42 as discussed, just wanted to check an exception has been filed already for this ?

humblec avatar Sep 15 '21 03:09 humblec

Hi @humblec, we'll submit an exception for this soon. CC @Jiawei0227

xing-yang avatar Sep 15 '21 12:09 xing-yang

Hi @humblec :wave: 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

ramrodo avatar Sep 22 '21 21:09 ramrodo

Hi @humblec , 1.23 Enhancements Shadow here.

In light of code freeze approaching on November 16th, please make sure to link your k/k code PR's in the description so the release team can keep track. As of now, the status of this enhancement is at-risk Thanks :)

gracenng avatar Nov 14 '21 17:11 gracenng

/milestone v1.23 An exception request was filed on 9/15/21 for the 1.23 Enhancements Freeze. The exception request was approved on 9/15/21

reylejano avatar Nov 15 '21 19:11 reylejano

/reopen Keep this open to track the feature all the way to GA

msau42 avatar Nov 16 '21 04:11 msau42

@msau42: Reopened this issue.

In response to this:

/reopen Keep this open to track the feature all the way to GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 16 '21 04:11 k8s-ci-robot

Hi @reylejano , this enhancement issue still shows "tracked/no". Can you change it to "tracked/yes"?

xing-yang avatar Nov 17 '21 17:11 xing-yang

/reopen

msau42 avatar Nov 30 '21 17:11 msau42

@msau42: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 30 '21 17:11 k8s-ci-robot

@msau42 @Jiawei0227 @xing-yang can we track the beta promotion of this enhancement here in this same issue ? or do we need a separate issue/tracker?

humblec avatar Jan 05 '22 09:01 humblec

I think we should use the same issue.

Jiawei0227 avatar Jan 05 '22 10:01 Jiawei0227

Thanks @Jiawei0227 for confirming.

humblec avatar Jan 05 '22 11:01 humblec

/milestone v1.24

xing-yang avatar Jan 11 '22 03:01 xing-yang

@humblec can you update the kep to indicate we want to promote to beta in 1.24?

msau42 avatar Jan 11 '22 03:01 msau42

@humblec can you update the kep to indicate we want to promote to beta in 1.24?

Done @msau42 , ptal.. thanks !

humblec avatar Jan 11 '22 08:01 humblec

Hello @humblec

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for v1.24,

Here’s where this enhancement currently stands:

  • [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for this release
  • [X] KEP has a test plan section filled out.
  • [X] KEP has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue description and the targeted stage up-to-date for release v1.24. Thanks!

hosseinsalahi avatar Jan 21 '22 09:01 hosseinsalahi

Hey @encodeflush

Updated KEP file using the latest template has been merged into the k/enhancements repo.

The migration feature here is a little bit complicated than other features. The ceph rbd csi migration is part of the overall CSI migration feature, and we already linked it to the original KEP here. So the PRR, test plan and everything was included in the following KEP already:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration

The Ceph RBD PR states that:

This inherits all the contents from its parent KEP. It will introduce two new feature gates to be 
used as as described in its parent KEP. For all other contents, please refer to the parent KEP.

We have communicated this with sig-release team in previous release and this has been agreed in previous releases. Please let me know if there is anything else we need to do. Thanks a lot!

Jiawei0227 avatar Jan 21 '22 19:01 Jiawei0227

@Jiawei0227 Thanks for the update. I updated the KEP status.

hosseinsalahi avatar Jan 28 '22 16:01 hosseinsalahi

Hi @humblec, 1.24 Docs shadow here. πŸ‘‹

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! πŸ™Œ

didicodes avatar Feb 13 '22 19:02 didicodes

uh oh, do we have the close in a commit msg problem...

msau42 avatar Feb 15 '22 20:02 msau42

This is weird!

ahg-g avatar Feb 16 '22 02:02 ahg-g

Hi @humblec πŸ‘‹ 1.24 RT Comms lead here. Would this be appropriate to include in our 1.24 Removals and Deprecations blog post?

mickeyboxell avatar Mar 16 '22 02:03 mickeyboxell