community icon indicating copy to clipboard operation
community copied to clipboard

added a playlist for WG Serving

Open SergeyKanzhelev opened this issue 1 year ago • 2 comments

/wg serving

related to https://github.com/kubernetes/community/issues/7850

SergeyKanzhelev avatar Apr 30 '24 19:04 SergeyKanzhelev

@SergeyKanzhelev: The label(s) wg/serving cannot be applied, because the repository doesn't have them.

In response to this:

/wg serving

related to https://github.com/kubernetes/community/issues/7850

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 30 '24 19:04 k8s-ci-robot

Looks like https://github.com/kubernetes/community/pull/7904 got merged faster than this one.

@SergeyKanzhelev Would you like to close this and update https://github.com/kubernetes/community/issues/7850?

terrytangyuan avatar May 21 '24 03:05 terrytangyuan

Looks like #7904 got merged faster than this one.

@SergeyKanzhelev Would you like to close this and update #7850?

I created https://github.com/SergeyKanzhelev/community-1/pull/2 to help with this

ArangoGutierrez avatar May 21 '24 10:05 ArangoGutierrez

Looks like #7904 got merged faster than this one.

@SergeyKanzhelev Would you like to close this and update #7850?

I created https://github.com/SergeyKanzhelev/community-1/pull/2 to help with this

This change is no longer needed since another same change has been merged

terrytangyuan avatar May 21 '24 11:05 terrytangyuan

Looks like #7904 got merged faster than this one.

@SergeyKanzhelev Would you like to close this and update #7850?

I created SergeyKanzhelev#2 to help with this

This change is no longer needed since another same change has been merged

Yeah I saw that, but noticed the links are different

ArangoGutierrez avatar May 21 '24 11:05 ArangoGutierrez

The links look the same to me

terrytangyuan avatar May 21 '24 11:05 terrytangyuan

The links look the same to me

PL69nYSiGNLP30qNanabU75ayPK7OPNAAS&si=XUgX-PkFahKEVxPg vs PL69nYSiGNLP30qNanabU75ayPK7OPNAAS

ArangoGutierrez avatar May 21 '24 11:05 ArangoGutierrez

Hmm I see. They both lead to the same playlist though so I am not sure if the difference is important.

terrytangyuan avatar May 21 '24 12:05 terrytangyuan

PL69nYSiGNLP30qNanabU75ayPK7OPNAAS&si=XUgX-PkFahKEVxPg vs PL69nYSiGNLP30qNanabU75ayPK7OPNAAS

The additional parameter si stands for session identifier or session info. This parameter is typically used by YouTube to track certain metadata about the user's session. It might include information for improved tracking, personalization, or analytics purposes.

I think CNCF users prefer links without data trackers

ArangoGutierrez avatar May 21 '24 13:05 ArangoGutierrez

thank you for noticing and fixing this PR!

SergeyKanzhelev avatar May 21 '24 17:05 SergeyKanzhelev

/test all

ArangoGutierrez avatar May 21 '24 17:05 ArangoGutierrez

/assign @pacoxu

Can you please help merge this?

SergeyKanzhelev avatar May 22 '24 20:05 SergeyKanzhelev

/approve

pacoxu avatar May 23 '24 00:05 pacoxu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, SergeyKanzhelev, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 23 '24 00:05 k8s-ci-robot