community icon indicating copy to clipboard operation
community copied to clipboard

Communication Guidelines edit

Open aaronepperson opened this issue 3 years ago • 17 comments

This updates the communication guidelines with edits and other updates for style guide formats.

Which issue(s) this PR fixes:

Fixes #

aaronepperson avatar Feb 14 '22 23:02 aaronepperson

Welcome @aaronepperson!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Feb 14 '22 23:02 k8s-ci-robot

Hi @aaronepperson. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 14 '22 23:02 k8s-ci-robot

/ok-to-test

mrbobbytables avatar Feb 14 '22 23:02 mrbobbytables

/assign to get it on my to-do list

mrbobbytables avatar Feb 14 '22 23:02 mrbobbytables

thanks for the PR! I've only done a quick skim and I'm finding a lot of empty [ ]'s after [link descriptions]. examples in the moderation docs. will do a formal review in a bit.

parispittman avatar Feb 15 '22 00:02 parispittman

@parispittman

thanks for the PR! I've only done a quick skim and I'm finding a lot of empty [ ]'s after [link descriptions]. examples in the moderation docs. will do a formal review in a bit.

The empty [] is another way of representing a reference link and is often put in there by markdown formatters.

Markdown is great for being flexible, but also annoying at how inconsistent it is lol

mrbobbytables avatar Feb 22 '22 13:02 mrbobbytables

@mrbobbytables do we have one way or another listed in the style guide? or are we accepting of all ways for markdown?

parispittman avatar Feb 23 '22 20:02 parispittman

@parispittman we don't have both ways listed in the style guide, but I'd personally accept both - I've seen both used with the trailing[] frequently injected by linters / auto formatters.

mrbobbytables avatar Mar 01 '22 12:03 mrbobbytables

Please make the cited changes, particularly Bob's fixes to the links. Then can merge. Sorry for the long review period, there's a lot of lines in this one!

jberkus avatar Mar 02 '22 17:03 jberkus

@jberkus @mrbobbytables I worked with Aaron to do tricky Git stuff and resolve all of the issues we could do, then I did a rebase and force push.

pymander avatar Mar 25 '22 17:03 pymander

/approved

@parispittman @mrbobbytables can one of you LGTM it?

jberkus avatar Mar 25 '22 21:03 jberkus

Grrr.

/approve

jberkus avatar Mar 25 '22 21:03 jberkus

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aaronepperson, jberkus, markyjackson-taulia To complete the pull request process, please ask for approval from mrbobbytables after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 25 '22 21:03 k8s-ci-robot

/lgtm

jberkus avatar Mar 30 '22 20:03 jberkus

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Apr 13 '22 20:04 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 12 '22 21:07 k8s-triage-robot

@aaronepperson: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 20 '22 04:07 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 19 '22 04:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Sep 21 '22 22:09 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 21 '22 22:09 k8s-ci-robot