client-go

client-go copied to clipboard

testing TokenReviews requires manipulating the created tokenReview object as part of the test while the submitted toeknReview object sent as part of Create is part of the code being tested.

Example code to be tested:

func (k *KubeMgr) validateToken(token string) (err error) {
	tr := authv1.TokenReview{
		Spec: authv1.TokenReviewSpec{
			Token:     token,
			Audiences: []string{ServiceAudience},
		},
	}
	tokenReview, err := k.cmClient.AuthenticationV1().TokenReviews().Create(context.TODO(), &tr, metav1.CreateOptions{})
	if err != nil {
		err = fmt.Errorf("tokenreviews failed %w - %v", err, tokenReview)
		return
	}
	if !tokenReview.Status.Authenticated {
		err = fmt.Errorf("not Authenticated- %v", tokenReview)
		return
	}
	return
}

The test should be able to manipulate for example the tokenReview.Status.Authenticated returned from the fake client AuthenticationV1().TokenReviews().Create(context.TODO(), &tr, metav1.CreateOptions{}).

Currently, the code returns the created object - i.e. tr in the code above is returned - which does not allow manipulating tokenReview.Status.Authenticated.

It is suggested that we use the tracker and in the case of tokenReview, the Create will return a matching tokenReview from the tracker.

/assign davidhadas

Alternative exists