autoscaler

autoscaler copied to clipboard

Which component this PR applies to?

vertical-pod-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4786

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add flags to specify recommender name and targetCPUPercentile via command line arguments.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jbartosik something like that? Let me know and I'll add some test coverage and docs.

/test

@matthyx: No presubmit jobs available for kubernetes/autoscaler@master

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale @jbartosik can check and tell me what's missing, please?

Please ping me when I should take another look

Please ping me when I should take another look

I have added tests, please check their integration... and I also have an issue when I require early abort.

Thanks @jbartosik I've missed that... does my change suit you?

@jbartosik thanks for your help, I think we're good to go :)

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~vertical-pod-autoscaler/OWNERS~~ [jbartosik]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/hold cancel

@jbartosik can you also change the "Draft" status of the PR? I cannot do it, strangely :(

/lgtm

@matthyx can you add some documentation on running multiple recommenders.

I think it can be quite simple, something like:

• a yaml with recommender with different cpu percentile and name in flag
• a short .md file pointing to the yaml and highlighting the flags and what they do.