structured-merge-diff

structured-merge-diff copied to clipboard

Question: example how to use structured merge diff from a controller

2

Hi, is there and example/some doc you can point me on how to use structured merge diff from a controller

fabriziopandini

Add test to verify that apply after update should work with no conflict

14

While investigating https://github.com/kubernetes/kubernetes/issues/107417 , I found that at least at the level of structured merge diff, `Apply` doesn't cause conflict with `Update` if manager name is the same. This PR...

redbaron

reconsider use of json-iterator / reflect2

14

The approach taken by json-iterator and its reflect library is not long-term stable (it pins to internal details of the stdlib reflect package), and requires maintenance per go release, which...

liggitt

Set list w/ atomic map types is not yet supported

16

https://github.com/kubernetes-sigs/structured-merge-diff/blob/17912732856ce1817c889fd8a8815083f6e0f826/typed/helpers.go#L211-L213 i was hitting above line when using an atomic map as the element of a set-list. is there a plan for supporting such schema? thanks! @apelisse @jennybuckley

yue9944882

Document how to use list-type and list-keys in a CRD, including in existing clusters.

12

I'm told that 1.16 supports interpreting a CRD which has `x-kubernetes-list-map-type` and `x-kubernetes-list-map-keys` properties. Please document somewhere an example of a CRD that uses these, so the syntax is clear....

erictune

Hello, We have observed in [Crossplane](https://github.com/crossplane/crossplane) project's [CNCF fuzzing tests](https://github.com/cncf/cncf-fuzzing/tree/main/projects/crossplane) that `runtime.DefaultUnstructuredConverter.ToUnstructured` (from `k8s.io/[email protected]`) consuming `sigs.k8s.io/structured-merge-diff/[email protected]` panics with the following sample program: ```go package main import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime"...

ulucinar

`dry-run` sometimes misses metadata and causes `failed to prune fields` error during CRD conversion

2

Hello! We are developing a custom operator and utilizing fluxCD. We have the `v1alpha1` custom resource which is deployed by fluxCD. When we upgraded the custom resource operator from `v1alpha1`...

LittleWat

broken link issue resolved

3

Signed-off-by: amolmote Fixes #225

amolmote

## Bug Report *Problem* [This page ](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/CONTRIBUTING.md) has one broken link of `contributor cheat sheet` which needs to fix. *solution* need to locate the correct path of README. /assign /kind...

amolmote

Migrate github.com/json-iterator/go to sigs.k8s.io/json

17

fixes https://github.com/kubernetes-sigs/structured-merge-diff/issues/202 Replaces "github.com/json-iterator/go" with "sigs.k8s.io/json" and "encoding/json". TODO: compare benchmarks before and after

inteon