prow icon indicating copy to clipboard operation
prow copied to clipboard

`gangway`: add status change endpoint

Open Prucek opened this issue 1 year ago • 6 comments

Resolves: https://github.com/kubernetes-sigs/prow/issues/115

Add new BulkJobStatusChange endpoint to change the status of multiple PJs.

Prucek avatar Apr 18 '24 12:04 Prucek

Welcome @Prucek!

It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prow has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Apr 18 '24 12:04 k8s-ci-robot

Hi @Prucek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 18 '24 12:04 k8s-ci-robot

Deploy Preview for k8s-prow ready!

Name Link
Latest commit bca239a039f04dc0fe2003673633238bad70835b
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/664610aea7c5e0000977a618
Deploy Preview https://deploy-preview-116--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 18 '24 12:04 netlify[bot]

/ok-to-test

petr-muller avatar Apr 18 '24 15:04 petr-muller

/retest-required

Prucek avatar May 16 '24 12:05 Prucek

/test pull-prow-unit-test-race-detector-nonblocking

Prucek avatar May 16 '24 12:05 Prucek

/retest-required

Prucek avatar May 16 '24 13:05 Prucek

/lgtm

smg247 avatar May 16 '24 19:05 smg247

/approve

petr-muller avatar May 17 '24 09:05 petr-muller

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 17 '24 09:05 k8s-ci-robot

This change is causing extensive flakes on the integration test.

upodroid avatar May 17 '24 14:05 upodroid

:+1: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_prow/155/pull-prow-integration/1791473589053034496#1:build-log.txt%3A887:

 === FAIL: test/integration/test TestGangwayBulkJobStatusChange (12.74s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x1b69d80] 

Let's revert

petr-muller avatar May 17 '24 14:05 petr-muller