nfs-subdir-external-provisioner

nfs-subdir-external-provisioner copied to clipboard

This relates to issue #149 and allows to use the PVName in the path pattern. This adds the ability to use the pvname as part of the pathpattern, the same way that is done in the default pattern. The default path pattern is now a string that is parsed the same way as the user specified pathpattern.

This addresses the issues in PR #157. I decided to start clean to address those issues, hence a new PR.

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale

updated branch to latest release and rebased code on top of that.

/ok-to-test

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

It would be nice to see this merged in.

Will look at the comments, and fix the PR /remove-lifecycle stale

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robkooper Once this PR has been reviewed and has the lgtm label, please assign kmova for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Is there plans to merge this change cause i'm very interested in having this variable accessible for setting pathPatern?https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/a398074e32ee4bcd3cfe53b12facad60b1528df9/cmd/nfs-subdir-external-provisioner/provisioner.go#L90

Is there plans to merge this change cause i'm very interested in having this variable accessible for setting pathPatern?

https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/a398074e32ee4bcd3cfe53b12facad60b1528df9/cmd/nfs-subdir-external-provisioner/provisioner.go#L90

also waiting for this one

Is there plans to merge this change cause i'm very interested in having this variable accessible for setting pathPatern? https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/blob/a398074e32ee4bcd3cfe53b12facad60b1528df9/cmd/nfs-subdir-external-provisioner/provisioner.go#L90

also waiting for this one

I'm also waiting, please merge ASAP

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale