kwok

kwok copied to clipboard

In my M1 env, I'd like to reuse the kubectl; otherwise you cannot download a darwin/arm64 kubectl binary:

w/o this PR, the following command won't work in M1:

KWOK_KUBE_VERSION=v1.20.15 kwokctl create cluster --runtime binary --kube-scheduler-binary /usr/local/bin/[email protected] --kube-controller-manager-binary /usr/local/bin/[email protected]  --kube-apiserver-binary /usr/local/bin/[email protected] --kwok-controller-binary /usr/local/bin/kwok --etcd-binary /opt/homebrew/bin/etcd --name 120-binary

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [Huang-Wei]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/kind bug

/retest

Ooops seems to have triggered another bug, I've fixed it, #44 merge first and then rebase this RP

Do we need to provide a way to disable kubectl in the path? Otherwise it will prompt

WARNING: version difference between client (1.24) and server (1.22) exceeds the supported minor version skew of +/-1

Do we need to provide a way to disable kubectl in the path? Otherwise it will prompt

It doesn't bother me as kubectl version skew is more robust than the skew among other core components.

/retest

/lgtm