kwok icon indicating copy to clipboard operation
kwok copied to clipboard

Kwok Stage Configs are not in expectation

Open mingyuanzhu opened this issue 1 year ago • 3 comments

How to use it?

  • [ ] kwok
  • [X] kwokctl --runtime=docker (default runtime)
  • [ ] kwokctl --runtime=binary
  • [ ] kwokctl --runtime=nerdctl
  • [ ] kwokctl --runtime=kind

What happened?

Just applied the general folder (https://github.com/kubernetes-sigs/kwok/tree/main/kustomize/stage/pod/general) stage configs but caused the pod status from running -> containerCreating -> running Z7Bg1fdUJx

What did you expect to happen?

I hope the status does not change to containerCreating after running.

How can we reproduce it (as minimally and precisely as possible)?

I just the kwok 4.0.0 and apply the general stages config (https://github.com/kubernetes-sigs/kwok/tree/main/kustomize/stage/pod/general)

Anything else we need to know?

No response

Kwok version

$ kwok --version
kwok version v0.4.0 go1.20.7 (linux/amd64)

$ kwokctl --version
kwokctl version v0.4.0 go1.21.0 (linux/amd64)

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a PRETTY_NAME="Debian GNU/Linux 10 (buster)" NAME="Debian GNU/Linux" VERSION_ID="10" VERSION="10 (buster)" VERSION_CODENAME=buster ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/"

On Darwin:

$ uname -a Linux n199-192-082 5.4.143.bsk.8-amd64 #5.4.143.bsk.8 SMP Debian 5.4.143.bsk.8 Wed Jul 20 08:43:36 UTC x86_64 GNU/Linux

On Windows:

C:> wmic os get Caption, Version, BuildNumber, OSArchitecture

paste output here

</details>

mingyuanzhu avatar Mar 20 '24 11:03 mingyuanzhu

@wzshiming Thanks a lot if you can help to check

mingyuanzhu avatar Mar 20 '24 11:03 mingyuanzhu

Thank you for your feedback. Although this is still experimental, there is no test coverage that looks like the expected behavior changes.

I plan to refine it in this release.

wzshiming avatar Mar 21 '24 03:03 wzshiming

Thank you for your feedback. Although this is still experimental, there is no test coverage that looks like the expected behavior changes.

I plan to refine it in this release.

After I upgraded the Kwok version to v0.5.1, it looks to work well. I saw that there were some PRs to refine the dequeue in playing the pod stages. Not sure if it has already been fixed.

mingyuanzhu avatar Mar 21 '24 04:03 mingyuanzhu

This has been fixed, feel free to open it if there are still issues

/close

wzshiming avatar May 16 '24 10:05 wzshiming

@wzshiming: Closing this issue.

In response to this:

This has been fixed, feel free to open it if there are still issues

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 16 '24 10:05 k8s-ci-robot