kind
kind copied to clipboard
kubernetes-sigs
migrate containerd registry endpoint to hosts.toml
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: matthyx
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval by writing /assign @bentheelder in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @matthyx. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Were it so easy https://kind.sigs.k8s.io/docs/user/local-registry/
https://github.com/kubernetes-sigs/kind/issues/2875
This change is a significant regression to our users and we don't have an obvious path forward. Today we make it easy to patch containerd config.
Tomorrow that will be useless and users will have to create and mount an additional file or we will have to add some other UX.
Also, when we enable this, these images become broken for users leveraging the existing format.
🍿 https://github.com/kubernetes/kubernetes/issues/110312#issuecomment-1265470633
it seems this will take some time
I think we will probably have to design a KIND registry config format to shim this, so we can backend it with either containerd inline or the hosts dir.
When doing so we also need to consider the longstanding feature request for a built-in registry user experience.
KIND probably won't be able to just sit on an LTS release forever, because it will block k8s development to not pick up new CRI features. It's unclear how long we have until 2.0 though.
do you have a KinDEP process ;-) ?
there was some try IIRC, I think that Ben also opened an issue about that
https://kind.sigs.k8s.io/docs/contributing/getting-started/ points to discussing designs in an issue before moving to implementation. You can see some examples of issues outlining designs.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
we just removed this config from the base image, we still need a good plan for how users can reasonably switch over with their custom registry configs. we have other much more pressing issues at the moment though.