cluster-inventory-api icon indicating copy to clipboard operation
cluster-inventory-api copied to clipboard

An initial ClusterProfile CRD implementation of KEP-4322: Cluster Profile API

Open mikeshng opened this issue 1 year ago • 5 comments

By community demand, this is the first go of ClusterProfile CRD implementation of KEP 4322.

Note: We are expecting the PR https://github.com/kubernetes/enhancements/pull/4533 to merge for the renaming of the API from ClusterInventory to ClusterProfile.

mikeshng avatar Apr 16 '24 23:04 mikeshng

/assign @ryanzhang-oss

/assign @qiujian16

mikeshng avatar Apr 16 '24 23:04 mikeshng

/assign I'll take a look. Thank you @mikeshng .

RainbowMango avatar Apr 17 '24 01:04 RainbowMango

We may also need to rename this repository.

dixudx avatar Apr 17 '24 02:04 dixudx

/cc

ArangoGutierrez avatar Apr 18 '24 16:04 ArangoGutierrez

This looks like a great start! I think there's a few questions about intended supportable functionality or use cases that would help clarify some of the open spec design questions.

We are making some KEP changes to clarify these design questions. This implementation PR will follow the KEP once it's merged.

mikeshng avatar May 07 '24 13:05 mikeshng

/lgtm

bsalamat avatar May 23 '24 17:05 bsalamat

@bsalamat: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 23 '24 17:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, ryanzhang-oss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [mikeshng,ryanzhang-oss]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 23 '24 20:05 k8s-ci-robot

/lgtm

ryanzhang-oss avatar May 23 '24 20:05 ryanzhang-oss