cluster-api-provider-azure icon indicating copy to clipboard operation
cluster-api-provider-azure copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Use GetAtScope() to get tags when checking if a resource is managed

Open Jont828 opened this issue 3 years ago • 3 comments

What type of PR is this? /kind feature

What this PR does / why we need it: Use GetAtScope() to get tags when checking if a resource is managed so we don't need to get the entire resource.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1899

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

Release note:

Jont828 avatar Oct 12 '22 00:10 Jont828

@CecileRobertMichon I think this is ready for a final pass of reviews!

Jont828 avatar Nov 01 '22 17:11 Jont828

/retest

Jont828 avatar Nov 03 '22 21:11 Jont828

This is such an awesome, often-underappreciated change, thanks @Jont828!

/lgtm

@CecileRobertMichon do we feel confident merging this in at the end of the 1.6 dev cycle? I think the mock tests tell the story here that this is non-breaking, but wonder if want more mileage on this before we release it.

jackfrancis avatar Nov 04 '22 18:11 jackfrancis

/lgtm /approve

jackfrancis avatar Nov 04 '22 21:11 jackfrancis

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 04 '22 21:11 k8s-ci-robot