cluster-api-provider-azure

cluster-api-provider-azure copied to clipboard

What type of PR is this? /kind feature

What this PR does / why we need it: Currently, there is no way to specify the backend pool name. Make LB's backend pool name customizable. The changes introduced in this PR are backward compatible and should not break existing deployments.

Special notes for your reviewer: Adding a struct Backend to API allows for future expansion of the configuration. If we later wanted to add some additional config, it would be preferable to have them all in a struct rather than BackendPoolName, BackendPoolPort, etc

TODOs:

• [X] squashed commits
• [ ] includes documentation
• [X] adds unit tests

Release note:

Allow to set custom backend pool names for load balancers

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign timothysc for approval by writing /assign @timothysc in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Thanks for picking this up from #2432 /lgtm

Thanks for picking this up @Fedosin! it looks like this is missing some of the changes that were made as part of the review that already happened on https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/2432, could you please make sure you're reconciling those?

New changes are detected. LGTM label has been removed.

@CecileRobertMichon Hi! I updated the PR as you asked. Could you take a look again?

/cc @nawazkh @willie-yao for additional 👀

@Fedosin please squash

/lgtm

@CecileRobertMichon now it's squashed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment