cluster-api-provider-azure

cluster-api-provider-azure copied to clipboard

/kind feature What steps did you take and what happened:

1. Run the E2E test script ./scripts/ci-e2e.sh.
2. Observe that files manager_pull_policy.yaml and manager_image_patch.yaml in config/default have been changed automatically.

What did you expect to happen: The test script should not edit files that can be committed. This results in many unintended changes to be committed, and some of these changes break the Tilt environment as well as other clusters when ran locally.

Anything else you would like to add:

Environment:

• cluster-api-provider-azure version: v1.5.1
• Kubernetes version: (use kubectl version): v1.24.4
• OS (e.g. from /etc/os-release): Ubuntu

/milestone v1.6

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale

We should still fix this. I've mistakenly committed these files twice this month, and I know better.

/help

@willie-yao: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@willie-yao is this done or close to done now that we have https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/Makefile#L220 ?

@CecileRobertMichon This is still happening as make clean-release-git is only ran in verify-container-images.sh. I'll see if I can include this in the ci-e2e.sh script.