cluster-api-provider-azure

cluster-api-provider-azure copied to clipboard

What type of PR is this?

/kind bug /kind cleanup

What this PR does / why we need it:

This PR updates AzureManagedCluster webhooks to prefer the approach from this PR: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/2376

This adds CRD feature-gate validation as part of the webhook validation, so that users get a clear message when attempting to create a resource currently behind a feature flag (e.g., AzureManagedCluster).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• [ ] squashed commits
• [ ] includes documentation
• [ ] adds unit tests

Release note:

standardize AzureManagedCluster webhooks

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon sorry, I didn't run lint prior to pushing up changes :( fixed

/lgtm

/retest

I don't know how to get this merged without a rebase. 1-2-3 here we go!

/test ls

@jackfrancis: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-azure-build
• /test pull-cluster-api-provider-azure-ci-entrypoint
• /test pull-cluster-api-provider-azure-e2e
• /test pull-cluster-api-provider-azure-test
• /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-azure-apidiff
• /test pull-cluster-api-provider-azure-apiversion-upgrade
• /test pull-cluster-api-provider-azure-capi-e2e
• /test pull-cluster-api-provider-azure-conformance
• /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-azure-e2e-csi-migration
• /test pull-cluster-api-provider-azure-e2e-exp
• /test pull-cluster-api-provider-azure-e2e-optional
• /test pull-cluster-api-provider-azure-e2e-workload-upgrade
• /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
• /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-azure-apidiff
• pull-cluster-api-provider-azure-build
• pull-cluster-api-provider-azure-ci-entrypoint
• pull-cluster-api-provider-azure-e2e
• pull-cluster-api-provider-azure-e2e-exp
• pull-cluster-api-provider-azure-test
• pull-cluster-api-provider-azure-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test pull-cluster-api-provider-azure-capi-e2e /test pull-cluster-api-provider-azure-e2e-optional /test pull-cluster-api-provider-azure-e2e-workload-upgrade /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

/hold

@jackfrancis since this is classified as a bug, can you please make the release note a bit more specific? "standardize" is a bit vague, users might wonder what is this fixing? Or maybe it would be better classified as a "cleanup" if it's not actually fixing any functional behavior

Feel free to unhold when you're done

/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon thanks for the review! I don't think this is a bug, I'll reclassify.

/hold cancel