cluster-api-provider-azure

cluster-api-provider-azure copied to clipboard

/kind feature

Describe the solution you'd like: Add unit tests for vm.go in the converters package similar to the other converters.

Environment:

• cluster-api-provider-azure version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

/assign willie-yao

@Jont828: GitHub didn't allow me to assign the following users: willie-yao.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign willie-yao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign

@Jont828 -- There has already been a test that I wrote sometime back https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/2166 ( Lost track of it ) Just trying save ourselves from multiple efforts ( if at all )

@sonasingh46 Thanks for pointing this out! I am new to the project and didn't realize this has been done already, sorry about that. Would you be willing to take over this issue and continue working on #2166? If not, I can also work on it and credit you for any tests you've written already.

@willie-yao -- No problem at all! I just wanted to make sure we do not repeat the efforts. Do not worry about credit and all. You go ahead and make the changes. I will close the PR in favour of yours.

@sonasingh46 Thank you so much! I'll take over the issue then. This is super helpful and I really appreciate it!