cluster-api-provider-azure

cluster-api-provider-azure copied to clipboard

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1365

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• [ ] squashed commits
• [ ] includes documentation
• [ ] adds unit tests

Release note:

Test for conversion from API versions

Thanks @sayantani11! Looks like you need to run make modules before make verify and make test could pass.

CAPZ stopped testing v1alpha3 in testgrid because it's no longer supported in general by Cluster API. What's the motivation in adding this test coverage?

Thanks @sayantani11! Looks like you need to run make modules before make verify and make test could pass.

CAPZ stopped testing v1alpha3 in testgrid because it's no longer supported in general by Cluster API. What's the motivation in adding this test coverage?

It was just there in the backlog, so decided to just make the PR for it. I was thinking if we can have one for v1aplha4 -> v1beta1 but I guess CAPZ already has that if I am not wrong.

It was just there in the backlog, so decided to just make the PR for it.

And thank you so much for doing so, I didn't mean to sound discouraging.

But when we had problems with v1alpha3 tests in testgrid recently, we decided to disable the tests, so I worry that this might have a similar status. I'll let other community members weigh in: I am often wrong, and this may have lasting value.

It wasn't discouraging at all🙌🏻

On Fri, Jul 1, 2022, 12:35 AM Matt Boersma @.***> wrote:

It was just there in the backlog, so decided to just make the PR for it.

And thank you so much for doing so, I didn't mean to sound discouraging.

But when we had problems with v1alpha3 upgrade tests in testgrid recently, we decided to disable the tests, so I worry that this might have a similar status. I'll let other community members weigh in: I am often wrong, and this may have lasting value.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/2437#issuecomment-1171573964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7Q7RT6LEWTWJYPA4NX37DVRXVWLANCNFSM52GCWFZQ . You are receiving this because you were mentioned.Message ID: @.*** com>

Even though we no longer support creating new v1alpha3 clusters, I still think it'd be valuable to have integration test coverage for v1alpha3 -> v1beta and v1alpha4 -> v1beta1 conversion since there could still be existing alpha clusters out there and we want to make sure we don't break conversion in the current releases.

It would be valuable to also add the same test to v1alpha4, even though it looks like CAPI never added one for v1alpha4 https://github.com/prksu/cluster-api/tree/main/api/v1alpha4

Even though we no longer support creating new v1alpha3 clusters, I still think it'd be valuable to have integration test coverage for v1alpha3 -> v1beta and v1alpha4 -> v1beta1 conversion since there could still be existing alpha clusters out there and we want to make sure we don't break conversion in the current releases.

It would be valuable to also add the same test to v1alpha4, even though it looks like CAPI never added one for v1alpha4 https://github.com/prksu/cluster-api/tree/main/api/v1alpha4

Should I try adding the ones for v1Alpha3=>v1beta1 and v1Alpha4=>v1beta1?

Should I try adding the ones for v1Alpha3=>v1beta1 and v1Alpha4=>v1beta1?

@sayantani11 if you're up for that, apparently it would be valuable. Could be a separate PR.

Should I try adding the ones for v1Alpha3=>v1beta1 and v1Alpha4=>v1beta1?

@sayantani11 if you're up for that, apparently it would be valuable. Could be a separate PR.

Sure!!!

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval by writing /assign @mboersma in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@sayantani11: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-verify	a2069746e32fba663fd57fa1107c5bcba4ede09c	link	true	/test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-ci-entrypoint	a2069746e32fba663fd57fa1107c5bcba4ede09c	link	true	/test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-test	a2069746e32fba663fd57fa1107c5bcba4ede09c	link	true	/test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-coverage	a2069746e32fba663fd57fa1107c5bcba4ede09c	link	false	/test pull-cluster-api-provider-azure-coverage

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/close

Doing some PR queue cleanup 🧹, please feel free to reopen when this is ready for review

@CecileRobertMichon: Closed this PR.

In response to this:

/close

Doing some PR queue cleanup 🧹, please feel free to reopen when this is ready for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.