cluster-api-provider-azure
cluster-api-provider-azure copied to clipboard
kubernetes-sigs
Add custom backend pool name
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, there is no way to specify the backend pool name. Make LB's backend pool name customizable. The changes introduced in this PR are backward compatible and should not break existing deployments.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
- [ ] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
Release note:
Add custom backend pool name
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alexeldeib for approval by writing /assign @alexeldeib in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@alexander-demichev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-azure-apidiff | be1d8253b383f9a7f6b87441f590efa07a230172 | link | false | /test pull-cluster-api-provider-azure-apidiff |
| pull-cluster-api-provider-azure-verify | be1d8253b383f9a7f6b87441f590efa07a230172 | link | true | /test pull-cluster-api-provider-azure-verify |
| pull-cluster-api-provider-azure-test | be1d8253b383f9a7f6b87441f590efa07a230172 | link | true | /test pull-cluster-api-provider-azure-test |
| pull-cluster-api-provider-azure-coverage | be1d8253b383f9a7f6b87441f590efa07a230172 | link | false | /test pull-cluster-api-provider-azure-coverage |
| pull-cluster-api-provider-azure-e2e | be1d8253b383f9a7f6b87441f590efa07a230172 | link | true | /test pull-cluster-api-provider-azure-e2e |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@alexander-demichev: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@alexander-demicev pls rebase, let's get this over the finish line
@CecileRobertMichon It has been carried on https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/2714, I believe that PR has been rebased and is up to date
Ha thanks, I forgot about that while doing some PR triage. I'll close this one to avoid future confusion. Will take a look at #2714 again.
/close
@CecileRobertMichon: Closed this PR.
In response to this:
Ha thanks, I forgot about that while doing some PR triage. I'll close this one to avoid future confusion. Will take a look at #2714 again.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.