cluster-api-provider-azure

cluster-api-provider-azure copied to clipboard

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates opentelemetry-go to v1.6.1, and its unstable packages to v0.28.0. Also updates the otel helm chart to v0.12.1.

See https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.6.1

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

I've tested this locally and metrics and traces to Jaeger work fine, but I can't see things in App Insights. Then I backed up to the main branch and tried there but also couldn't see them in App Insights. So...I think this PR is sane but I'm unable to verify yet and will continue testing.

TODOs:

• [x] squashed commits
• [ ] includes documentation
• [ ] adds unit tests

Release note:

NONE

/hold

I haven't been able to verify that traces to App Insights are still working, so let's keep this from merging until I can figure that out.

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma by writing /assign @mboersma in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/retitle Update opentelemetry-go to v1.8.0

/hold

I'm still trying to verify that this works with App Insights.

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

/lifecycle active

/retitle Update opentelemetry-go to v1.9.0

@mboersma can we close this and reopen when it's ready for review?

/remove-lifecycle active

/close

I'll reopen when time permits to revisit this. At this point, I think we should remove App Insights support in order to stay current with otel.

@mboersma: Closed this PR.

In response to this:

/close

I'll reopen when time permits to revisit this. At this point, I think we should remove App Insights support in order to stay current with otel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.