cluster-api-provider-azure

cluster-api-provider-azure copied to clipboard

Goals

1. Tag all resources

User Story

As a user I would like to tag all AKS-related resources.

Detailed Description

I noticed the property additionalTags is defined in most CRDs but not in AzureManagedMachinePool. Why? Doesn’t it make sense in this context?

$ grep -rnw config/crd/ -e additionalTags
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachinetemplates.yaml:57:                      additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachinetemplates.yaml:407:                      additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachinetemplates.yaml:780:                      additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azureclusters.yaml:66:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azureclusters.yaml:463:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azureclusters.yaml:1294:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachinepools.yaml:76:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachinepools.yaml:595:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachinepools.yaml:1350:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremanagedcontrolplanes.yaml:62:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremanagedcontrolplanes.yaml:222:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremanagedcontrolplanes.yaml:527:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachines.yaml:77:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachines.yaml:535:              additionalTags:
config/crd//bases/infrastructure.cluster.x-k8s.io_azuremachines.yaml:1048:              additionalTags:

It confuses me since there is such property in AWSManagedMachinePool.

/kind proposal

@thof thanks for opening the issue. The Managed AKS cluster feature in CAPZ is still experimental and missing some configuration options. We'd accept a PR to enable this.

/area managedclusters /kind feature /help

@CecileRobertMichon: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

@thof thanks for opening the issue. The Managed AKS cluster feature in CAPZ is still experimental and missing some configuration options. We'd accept a PR to enable this.

/area managedclusters /kind feature /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale

/milestone next

@zmalik do you have plans to work on this in the next iteration?

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

/remove-lifecycle rotten