cluster-api-provider-aws

cluster-api-provider-aws copied to clipboard

What type of PR is this? /kind bug

What this PR does / why we need it: Fix delete rosaControlPlane and rosaMachinePool

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #4936

Special notes for your reviewer:

Checklist:

• [ ] squashed commits
• [ ] includes documentation
• [ ] includes emojis
• [ ] adds unit tests
• [ ] adds or updates e2e tests

Release note:

None

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign stevekuznetsov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• controlplane/rosa/OWNERS
• exp/controllers/OWNERS
• pkg/cloud/scope/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cc @muraee

/cc @vincepri

/area provider/rosa /ok-to-test

/hold

/unhold

@nrb would you approve this PR

/approve

Thanks! How do we know this work? We need to start working towards having CI gating in place, that might be a full rosa CRUD, that might be something lighter for starters.

Thanks! How do we know this work? We need to start working towards having CI gating in place, that might be a full rosa CRUD, that might be something lighter for starters.

There is e2e and integration test effort is happening, I believe it will be in another PR.

lgtm pending Daniels open comments

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [dlipovetsky]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@enxebre would you lgtm the PR

@dlipovetsky Do you have any other comment on the PR ? would you lgtm if not

/lgtm