cluster-api-provider-aws

cluster-api-provider-aws copied to clipboard

What type of PR is this? /kind cleanup

What this PR does / why we need it: In Gomega, when Eventually().Should() fails, the failure returns a

  [FAILED] Timed out after 1200.001s.
  Expected
      <bool>: false
  to be true

Which takes a bit of time to then debug further.

There is a more immediate way to add some context to this, by adding a failure message to the should like so: .Should(x, "message"). This PR does this for all the current occurrences of this construct.

Release note:

test: add failure message to Eventually().Should(bool) everywhere

/assign @nrb @richardcase

/lgtm

/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-eks

/assign @richardcase @dlipovetsky

/approve

Thanks for improving the tests!

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [dlipovetsky]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment