cloud-provider-azure

cloud-provider-azure copied to clipboard

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@zhougw001: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The committers are authorized under a signed CLA.

• :white_check_mark: zhougw (425e01ef1adeac8bfdb9d72ef6b8f2cee90723df, 4e9ccc6f62a75a026b0fd89b6764344095daa84c)

Welcome @zhougw001!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

Hi @zhougw001. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhougw001 To complete the pull request process, please assign feiskyer after the PR has been reviewed. You can assign the PR to them by writing /assign @feiskyer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Thanks @zhougw001, please following the link above to get the CLA Authorization. /ok-to-test

Coverage remained the same at 80.007% when pulling b137e266dd8ee7e87c4d329d975eb144eb0ed452 on zhougw001:master into 63c66b8bfd2db225cfaa4cb8502be6a8e6c67c6f on kubernetes-sigs:master.

@zhougw001 thanks for the contribution. Could you sign CLA?

@zhougw001 Do you still have bandwidth to deal with these code changes?

@zhougw001: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhougw001: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-azure-e2e-ccm	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm
pull-cloud-provider-azure-e2e-ccm-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-capz
pull-cloud-provider-azure-e2e-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-capz
pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhougw001: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-azure-e2e-ccm	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm
pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb
pull-cloud-provider-azure-e2e-ccm-vmssflex-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz
pull-cloud-provider-azure-unit	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-unit
pull-cloud-provider-azure-e2e-ccm-vmss-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-capz
pull-cloud-provider-azure-e2e-ccm-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-capz
pull-cloud-provider-azure-e2e-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhougw001: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-azure-e2e-ccm	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm
pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb
pull-cloud-provider-azure-e2e-ccm-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-capz
pull-cloud-provider-azure-e2e-ccm-vmssflex-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz
pull-cloud-provider-azure-e2e-ccm-vmss-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-ccm-vmss-capz
pull-cloud-provider-azure-unit	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-unit
pull-cloud-provider-azure-e2e-capz	b137e266dd8ee7e87c4d329d975eb144eb0ed452	link	true	/test pull-cloud-provider-azure-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name	Link
🔨 Latest commit	6335e2ebcb7107bf886f8b66af0200bf9488e68c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/640fe2c4152d100008c371a4
😎 Deploy Preview	https://deploy-preview-987--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhougw001

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment