cloud-provider-azure

cloud-provider-azure copied to clipboard

Duplicate annotation: "service.beta.kubernetes.io/service.beta.kubernetes.io/azure-disable-load-balancer-floating-ip"

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Hi @braieralves. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name	Link
🔨 Latest commit	0e0c48141f5a567dba032fd0d88a367e0692e9ad
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/665e09fdb26e4500084437b7
😎 Deploy Preview	https://deploy-preview-6188--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

/approve

/ok-to-test /lgtm /approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: braieralves, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [MartinForReal]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@braieralves Could you please fix the spelling error? Thanks!

Hello, @MartinForReal . Sorry but this spelling error didn't come from my PR.

Looks like this came from https://github.com/kubernetes-sigs/cloud-provider-azure/pull/5225

What should i do, please?

Thank you

@nilo19 Could you please fix the spelling error? Thanks!

/kind cleanup

@braieralves can you help fix the typos reported by CI test in your PR? Thanks.

Hello, @nilo19 To be honest, i don't know why this error is being reported in my PR.

But this error is about this word:

Maybe you can change this word to the correct suggestion? https://github.com/kubernetes-sigs/cloud-provider-azure/pull/5225

@braieralves that's not relevant to your change, just because your PR is also about fixing a typo so I asked if you are willing to fix another one. I will file a PR to fix this. Thanks anyway.

@nilo19 . I don't care to fix any other error :)

My point is, i didn't find where to do this.

Thank you