external-provisioner icon indicating copy to clipboard operation
external-provisioner copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

test: add codespell github workflow and templates for issues/RFEs.

Open humblec opened this issue 3 years ago • 3 comments

Signed-off-by: Humble Chirammal [email protected]

/kind failing-test

-->

NONE

humblec avatar Jul 29 '22 16:07 humblec

This looks good.

as discussed in https://github.com/kubernetes-csi/livenessprobe/pull/149#issuecomment-1128413164

That comment is regarding trivy vulnerability scanner. I don't see anything about these changes. Did you add the right reference?

xing-yang avatar Aug 04 '22 12:08 xing-yang

This looks good.

as discussed in kubernetes-csi/livenessprobe#149 (comment)

That comment is regarding trivy vulnerability scanner. I don't see anything about these changes. Did you add the right reference?

I was planning to add that too here, but on a second thought, kept only one action codespell and templates in this. Trivvy will be a follow up PR. I have removed that references from the comment.. @xing-yang

humblec avatar Aug 04 '22 17:08 humblec

/lgtm /approve

xing-yang avatar Aug 31 '22 14:08 xing-yang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 31 '22 14:08 k8s-ci-robot