external-provisioner

external-provisioner copied to clipboard

What type of PR is this? /kind feature

What this PR does / why we need it: Support secret in NodeExpansion Call

Which issue(s) this PR fixes: Fixes #499

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support secret in NodeExpansion Call

This feature ( NodeExpandSecret) need latest master branch dependencies.. so the update to 1.25.x tree.. Cc @xing-yang

@zhucan can you please rebase this PR to master.. we got the 1.25 dependency already , so rest can be kept here.

I have updated the release note section @zhucan , ptal.

@msau42 @xing-yang @jsafrane we need this PR part of the sidecar for e2e workflow of the feature we added in Kubernetes. ptal . thanks.

We also have a choice of placing this under a feature flag for this sidecar.

@zhucan, please do not forget to update https://github.com/kubernetes-csi/docs/blob/master/book/src/external-provisioner.md

/lgtm /approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, zhucan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@zhucan, please do not forget to update https://github.com/kubernetes-csi/docs/blob/master/book/src/external-provisioner.md

copy that, other pr is ok? @jsafrane

@zhucan, please do not forget to update https://github.com/kubernetes-csi/docs/blob/master/book/src/external-provisioner.md

copy that, other pr is ok? @jsafrane

Yeah, that change has go in another repo.