csi-driver-smb

csi-driver-smb copied to clipboard

What type of PR is this? /kind feature

What this PR does / why we need it: feat: support windows host-process deployment

Which issue(s) this PR fixes:

Fixes #

Requirements:

• [ ] uses conventional commit messages
• [ ] includes documentation
• [ ] adds unit tests
• [ ] tested upgrade from previous version

Special notes for your reviewer:

Release note:

feat: support windows host-process deployment

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/retest

/test pull-csi-driver-smb-e2e-capz

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz-windows-2019

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/retest

/test pull-csi-driver-smb-e2e-capz /test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz /test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/retest

/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz /test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/retest

/retest

/test pull-csi-driver-smb-e2e-capz /test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz-windows-2019

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/retest

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess /test pull-csi-driver-smb-e2e-capz-windows-2019

Pull Request Test Coverage Report for Build 9042206555

Details

• 3 of 160 (1.88%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-9.1%) to 69.955%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/smb/fake_mounter.go	0	1	0.0%
pkg/csi-common/utils.go	0	10	0.0%
pkg/os/smb/smb.go	0	32	0.0%
pkg/os/filesystem/filesystem.go	0	114	0.0%
<!--	Total:	3	160

Totals
Change from base Build 9032641981:	-9.1%
Covered Lines:	943
Relevant Lines:	1348

---

💛 - Coveralls

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-csi-driver-smb-sanity	bc9633723666c836ce09e6625fcbe7f0568a9989	link	true	/test pull-csi-driver-smb-sanity
pull-csi-driver-smb-e2e-capz-windows-2019	bc9633723666c836ce09e6625fcbe7f0568a9989	link	false	/test pull-csi-driver-smb-e2e-capz-windows-2019
pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess	bc9633723666c836ce09e6625fcbe7f0568a9989	link	false	/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten