csharp

csharp copied to clipboard

The code does not handle the case when Cert Flags are set and Windows is the platform and .net 5 or greater is used

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: bootleg224 (c71fa85e8908f2894b1d67450e9f7902b7fe752b)

Welcome @bootleg224!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

please sign cla

should it be added to https://github.com/kubernetes-client/csharp/blob/624ee292f749f8192916b544a0f8d918277ced55/src/KubernetesClient/CertUtils.cs#L99 as well?

CLA Signed, and and yes line you identified should also apply cert flags

you have make the author of the commit the same email as cla

I've updated my email in my profile to match the CLA : https://github.com/bootleg224

github cant figure out the author of this commit

git commit --amend --reset-author

ping @bootleg224

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bootleg224, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [tg123]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ping @bootleg224

I have signed the CLA it is unclear what else I need to do

@bootleg224 could you please git commit --reset-author to set the commit author with sla signed email

/LGTM