kubermatic icon indicating copy to clipboard operation
kubermatic copied to clipboard

fix kubevirt resource quota with vmipreset

Open sankalp-r opened this issue 3 years ago • 18 comments

What this PR does / why we need it: This PR fixes the fetching of VMIPresets for kubevirt cluster which is required during resource quota validation.

Which issue(s) this PR fixes:

Fixes #10768

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

Signed-off-by: Sankalp Rangare [email protected]

sankalp-r avatar Aug 17 '22 07:08 sankalp-r

/approve

lsviben avatar Aug 17 '22 08:08 lsviben

/retest

sankalp-r avatar Aug 17 '22 08:08 sankalp-r

/test pre-kubermatic-e2e-kubevirt-centos-1.24 /test pre-kubermatic-e2e-kubevirt-ubuntu-1.24

mfranczy avatar Aug 17 '22 10:08 mfranczy

/lgtm /approve

mfranczy avatar Aug 17 '22 10:08 mfranczy

LGTM label has been added.

Git tree hash: ac8c7f7e1a57468df9a24bd09c6b82bb68453716

kubermatic-bot avatar Aug 17 '22 10:08 kubermatic-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, mfranczy, sankalp-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [lsviben,mfranczy,sankalp-r]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Aug 17 '22 10:08 kubermatic-bot

/retest

sankalp-r avatar Aug 17 '22 11:08 sankalp-r

/hold temporarily

xrstf avatar Aug 17 '22 11:08 xrstf

/hold cancel

xrstf avatar Aug 17 '22 11:08 xrstf

Don't worry, I am just closing this to kickstart new Prowjobs.

xrstf avatar Aug 17 '22 11:08 xrstf

/retest

xrstf avatar Aug 17 '22 11:08 xrstf

/retest

sankalp-r avatar Aug 17 '22 12:08 sankalp-r

/retest

sankalp-r avatar Aug 17 '22 13:08 sankalp-r

/test pre-kubermatic-e2e-kubevirt-centos-1.24

mfranczy avatar Aug 17 '22 13:08 mfranczy

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubermatic-triage-bot avatar Aug 17 '22 15:08 kubermatic-triage-bot

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubermatic-triage-bot avatar Aug 17 '22 17:08 kubermatic-triage-bot

/hold

sankalp-r avatar Aug 17 '22 17:08 sankalp-r

/retest

mfranczy avatar Aug 18 '22 08:08 mfranczy

/hold cancel

sankalp-r avatar Aug 18 '22 09:08 sankalp-r

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubermatic-triage-bot avatar Aug 18 '22 11:08 kubermatic-triage-bot