kured icon indicating copy to clipboard operation
kured copied to clipboard

slack-username not respected

Open dholbach opened this issue 3 years ago • 5 comments
trafficstars

slack-username is not respected any more.

❯ git grep -i "slack.*username"
README.md:      --slack-username string               slack username for reboot notfications (default "kured")
charts/kured/README.md:| `configuration.slackUsername` | cli-parameter `--slack-username`                                      | `""`                      |
charts/kured/templates/daemonset.yaml:          {{- if .Values.configuration.slackUsername }}
charts/kured/templates/daemonset.yaml:            - --slack-username={{ .Values.configuration.slackUsername }}
charts/kured/values.minikube.yaml:  # slackUsername: ""         # slack username for reboot notfications (default "kured")
charts/kured/values.yaml:  slackUsername: ""          # slack username for reboot notfications (default "kured")
cmd/kured/main.go:      slackUsername                   string
cmd/kured/main.go:      rootCmd.PersistentFlags().StringVar(&slackUsername, "slack-username", "kured",
cmd/kured/main.go:              "slack username for notifications")
kured-ds.yaml:#            - --slack-username=prod

kured on  main via 🐹 v1.16.12 
❯ 

This came up after #368 (along with #469).

I'm a bit unsure what to do. I feel that going with shoutrrr is the right thing to do, but some "old" setups won't work they used to any more.

dholbach avatar Dec 14 '21 09:12 dholbach

Looks like channel is not respected either... at least it looks like it in our deployments 😕

Starefossen avatar Jan 24 '22 09:01 Starefossen

@atighineanu Can you help?

dholbach avatar Jan 24 '22 10:01 dholbach

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

github-actions[bot] avatar Mar 26 '22 02:03 github-actions[bot]

We still have this issue.

  • upgraded to chart version 1.12.1
  • changed to --notify-url

slack-username is not respected. Message to slack is sendt as Kured.

bengtfredh avatar Mar 30 '22 12:03 bengtfredh

After some testing I found that this works:

--notify-url=slack://myslackusername@token-a/token-b/token-c

Looks like --slack-username is deprecated too.

bengtfredh avatar Mar 31 '22 09:03 bengtfredh