xgboost-operator icon indicating copy to clipboard operation
xgboost-operator copied to clipboard

small installation tips for windows user

Open xfate123 opened this issue 5 years ago • 6 comments

small installation tips for windows user

xfate123 avatar Jun 03 '20 01:06 xfate123

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign terrytangyuan You can assign the PR to them by writing /assign @terrytangyuan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 03 '20 01:06 k8s-ci-robot

This change is Reviewable

kubeflow-bot avatar Jun 03 '20 01:06 kubeflow-bot

Hi @xfate123. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 03 '20 01:06 k8s-ci-robot

@terrytangyuan I am testing the new implementation right now, looks like there is a RunContainerError, should we update the image version in our deployment config file from v0.1.0 to v0.1.0-7-g34d49cc?

xfate123 avatar Jun 03 '20 02:06 xfate123

@terrytangyuan I am testing the new implementation right now, looks like there is a RunContainerError, should we update the image version in our deployment config file from v0.1.0 to v0.1.0-7-g34d49cc?

I've created a separate issue https://github.com/kubeflow/xgboost-operator/issues/89#issue-629998609 for this. For now, we can probably updating it manually.

terrytangyuan avatar Jun 03 '20 13:06 terrytangyuan

@terrytangyuan sounds good

xfate123 avatar Jun 03 '20 16:06 xfate123