model-registry

model-registry copied to clipboard

closes https://github.com/kubeflow/model-registry/issues/1075 Reduce tech debt in client and increase developer experience both as library and while developing.

Description

1. Updated docs
2. Rename and ensure utility functions are correctly named
3. Refactor S3 helper funcs into utils.py
4. Add support for large model uploads to S3
5. Tested support for large models uploads regressively
6. Fixed lingering Temp dir from older client release generated when a default path is used
7. Other general fixes and improvements

How Has This Been Tested?

Tests added: tests/test_client.py Fixture added to: conftest.py

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• [x] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
• [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• [x] The developer has manually tested the changes and verified that the changes work.
• [x] Code changes follow the kubeflow contribution guidelines.
• [ ] For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

• [ ] The developer has added tests or explained why testing cannot be added.
• [ ] Included any necessary screenshots or gifs if it was a UI change.
• [ ] Verify that UI/UX changes conform the UX guidelines for Kubeflow.