fairing icon indicating copy to clipboard operation
fairing copied to clipboard

Add documentation for dependency installation feature

Open yashjakhotiya opened this issue 5 years ago • 11 comments

What this PR does / why we need it: Without documentation, users might struggle in installation of additional python packages in the built docker image required for fairing jobs. This PR mentions the special role of 'requirements.txt' in input_files list of ml_tasks.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #NONE

Special notes for your reviewer:

This is a documentation update PR

Release note:

NONE

yashjakhotiya avatar Jun 25 '20 12:06 yashjakhotiya

This change is Reviewable

kubeflow-bot avatar Jun 25 '20 12:06 kubeflow-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jinchihe You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 25 '20 12:06 k8s-ci-robot

Hi @yashjakhotiya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 25 '20 12:06 k8s-ci-robot

/assign @jinchihe

yashjakhotiya avatar Jun 25 '20 12:06 yashjakhotiya

/ok-to-test

jinchihe avatar Jun 28 '20 05:06 jinchihe

/retest

jinchihe avatar Jun 28 '20 05:06 jinchihe

@jinchihe this is only a documentation update. Ideally, this should not fail any presubmit test.

yashjakhotiya avatar Jun 28 '20 06:06 yashjakhotiya

@jinchihe this is only a documentation update. Ideally, this should not fail any presubmit test.

Yeah, that should be caused by test tenv, I will take a look later once get chance. Thanks.

jinchihe avatar Jun 28 '20 09:06 jinchihe

/retest

jinchihe avatar Jun 30 '20 02:06 jinchihe

@yashjakhotiya: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-fairing-presubmit 0505b25e0728a892768340a56f159a0b55fd0cd8 link /test kubeflow-fairing-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jun 30 '20 02:06 k8s-ci-robot

@yashjakhotiya The CI testing problem has been fixed, would you please fetch and rebase? thanks a lot!

jinchihe avatar Jul 07 '20 15:07 jinchihe