common

common copied to clipboard

Per comment in https://github.com/kubeflow/tf-operator/pull/1171#discussion_r439856038, given that each operator may have different labels, we should discuss whether we want to allow each operator's controller that implements JobController to change ReplicaIndexLabel and ReplicaTypeLabel. For example, something like the following for tf-operator:

func (jc *JobController) GetReplicaTypeLabelKey() string {
	return tfReplicaTypeLabel
}

cc @gaocegege @Jeffwan @ChanYiLin @johnugeorge

Issue-Label Bot is automatically applying the labels:

Label	Probability
area/operator	0.92
kind/feature	0.73

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

Issue-Label Bot is automatically applying the labels:

Label	Probability
feature	0.73

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

I think we can have an interface there, and leave replica-type as default implementation in kubeflow/common, different operators can still override it if there's a need.

Yes they should be able to override the defaults.

I will take the issue /assign @ChanYiLin