common [Feature Request] Provides a better common logger

[Feature Request] Provides a better common logger

Open Jeffwan opened this issue 5 years ago • 3 comments

Currently, kubeflow/common provides a logger utils for operator to use. It uses github.com/sirupsen/logrus underneath.

https://github.com/kubeflow/common/blob/master/pkg/util/logger.go#L20

The problem I notice is new operators using kubebuilder have inbuilt logger for operator logics. This makes the logs really messy.

Can we provide a interface layer like logr and provide method like SetLogger and different operator can use their own implementation?

Apr 05 '20 20:04 Jeffwan

Issue-Label Bot is automatically applying the labels:

Label	Probability
feature	0.97

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

Apr 05 '20 20:04 issue-label-bot[bot]

Agreed. Having a unified interface would make it easier for downstream apps to consume the logs.

Apr 06 '20 14:04 terrytangyuan

cc @ShuhanYan @carmark in case you are interested

May 11 '20 01:05 terrytangyuan