seahorse icon indicating copy to clipboard operation
seahorse copied to clipboard

Published 20 hours ago • verified publisher icon ksk001100

Add u64 flag type

Open teodor-pripoae opened this issue 3 years ago • 1 comments

teodor-pripoae avatar May 13 '22 10:05 teodor-pripoae

thank you for PR, @teodor-pripoae

the idea seems good, however, this implementation will make inconsistency with FlagValue::Int(isize) . It may well be good to change FlagValue::Int(isize) to FlagValue::Int(i64) . any thoughts?

rnitta avatar May 13 '22 12:05 rnitta

Hi,

Any plans to merge this one ? I've made the required changes to rename it to UInt.

teodor-pripoae avatar Nov 16 '22 10:11 teodor-pripoae

@teodor-pripoae

Sorry I haven't responded in a long time. Change u64 to usize to be consistent with Int(isize)

ksk001100 avatar Nov 16 '22 11:11 ksk001100

Ok, changed it.

teodor-pripoae avatar Nov 16 '22 14:11 teodor-pripoae

@teodor-pripoae Thanks!!

ksk001100 avatar Nov 16 '22 14:11 ksk001100