models-web-app

models-web-app copied to clipboard

Currently it is not possible to edit existing model servers from the web app.

This PR adds a new edit function that lets the users change the existing YAML. It uses the k8s replace_namespaced_custom_object in the backend.

This will resolve https://github.com/kserve/models-web-app/issues/2 because the user can add the canaryTrafficPercent and change the storageUri

@kimwnasptd Can you review this please?

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markwinter To complete the pull request process, please assign kimwnasptd after the PR has been reviewed. You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/retest

@markwinter Please rebase to master

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markwinter Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval by writing /assign @juliusvonkohout in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Alright then you have to fix the broken tests.