actions-sync icon indicating copy to clipboard operation
actions-sync copied to clipboard

Consistently use `ubuntu-latest`?

Open IndrajeetPatil opened this issue 3 years ago • 5 comments

Currently, some actions use ubuntu-18.04, while others ubuntu-latest.

@krlmlr If you agree, I can make this change.

IndrajeetPatil avatar Oct 13 '22 11:10 IndrajeetPatil

Thanks. I have a slight preference for fixing the version (e.g. 20.04 instead of "latest"). Will everything continue to work when we upgrade to 20.04? Should we maybe even deliberately test things on older images too?

krlmlr avatar Oct 13 '22 14:10 krlmlr

Let's switch to Ubuntu 22. We also need to switch to Node 16, e.g., https://github.com/r-dbi/DBItest/actions/runs/3270079958. Can we do this in one swoop?

Tests for Ubuntu 20.04 and Ubuntu 18.04 should be part of #23.

krlmlr avatar Oct 18 '22 02:10 krlmlr

We also need to switch to Node 16

IINM, those warnings are coming from r-lib/actions: https://github.com/r-lib/actions/issues/626 We don't specify Node version anywhere.

IndrajeetPatil avatar Oct 18 '22 06:10 IndrajeetPatil

Do we need to use a newer tag for actions/checkout?

krlmlr avatar Oct 19 '22 07:10 krlmlr

No, I don't think we need to.

IndrajeetPatil avatar Oct 19 '22 08:10 IndrajeetPatil

I'm glad we didn't use ubuntu-latest because R is no longer available by default on ubuntu-24.04 and some workflows rely on it.

krlmlr avatar Jun 26 '24 19:06 krlmlr