TfsNotificationRelay

TfsNotificationRelay copied to clipboard

Is this planned? I updated recently from 2017.0 to 2017.3, and after updating this plugin to the latest on master everything seems to be working for the most part, except pull request votes look a little strange. Each vote seems to be coming in with a long guid instead of the user's mapped name, which is weird because the name comes in fine on regular pull request comment events.

Example of the PR vote message:

000007F5-0000-8888-8000-000000000000@00000000-0000-0000-0000-000000000000 commented on...

This showed up before update 3. They started sending both a vote event and a comment event when voting. So you'll first get:

kria approved the changes in pull request #8 in TestCompany/BotTest - bleh

and then:

000007F5-0000-8888-8000-000000000000@00000000-0000-0000-0000-000000000000 commented on pull request #8 in ...

That second one is from the system account. I should probably look into blocking these by default, but for now you can filter them out by adding a teamName criteria.

<rule notify="true" events="PullRequestComment" teamName=".*" />

This means that the commenter has to be a member of a team that matches that regex, and since the system account isn't a member of any team, it won't match that rule.

Thanks, adding that filter did the trick and removed the system account events. Everything else that we're using seems to be working with update 3, so I couldn't really say if further support for it is needed or not.